Update SQL all table/schemas reading functions to return maps with table names #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the SQL table reading functions to return map data structures instead of list. This change helps to easily correlate each dataframe with its underlying table. Additionally, the function comments and test cases were updated to match this change.
Jolanrensen
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Looks good :)
The only concern I have is with notebooks. Since we load the tables and we know the names, we should be able to generate safe accessors for them (like for a DataRow). Maybe something like #719 could help with that. But that's for the future :) for now it's a good change
|
|
||
| while (tables.next()) { | ||
| val table = dbType.buildTableMetadata(tables) | ||
| if (!dbType.isSystemTable(table)) { | ||
| // we filter her second time because of specific logic with SQLite and possible issues with future databases | ||
| // we filter her a second time because of specific logic with SQLite and possible issues with future databases |
dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt
Show resolved
Hide resolved
Typographical errors in the comments of the readJdbc.kt file were corrected for clarity. Additionally, the MSSQLTest class in the mssqlTest.kt file was annotated with "@ignore" to skip the test in subsequent testing runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671
Refactored the SQL table reading functions to return map data structures instead of list. This change helps to easily correlate each dataframe with its underlying table. Additionally, the function comments and test cases were updated to match this change.