Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for replaceAll #738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Documentation for replaceAll #738

wants to merge 2 commits into from

Conversation

koperagen
Copy link
Collaborator

@koperagen koperagen commented Jun 14, 2024

I decided to experiment with a new dataset

@koperagen koperagen self-assigned this Jun 14, 2024
@koperagen koperagen added the documentation Improvements or additions to documentation (not KDocs) label Jun 14, 2024
@koperagen koperagen added this to the 0.14.0 milestone Jun 14, 2024
@koperagen koperagen marked this pull request as draft June 14, 2024 19:20
@koperagen koperagen marked this pull request as ready for review June 19, 2024 14:56
Copy link
Contributor

Generated sources will be updated after merging this PR.
Please inspect the changes in here.

@koperagen
Copy link
Collaborator Author

image

<!---FUN replaceAll-->

```kotlin
functions.replaceAll(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the replaceAll call looks a bit out of place in between all these update functions, it should be in replace, shouldn't it? https://kotlin.github.io/dataframe/replace.html

Fillnulls https://kotlin.github.io/dataframe/fill.html is also an update "flavour", just like replaceAll, but it also has a separate page

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could provide a link from here to replaceAll though, but probably at the bottom

Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as commented :)

@koperagen koperagen modified the milestones: 0.14.0, 0.15.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants