Improve codegen for stdlib <-> df interop workflow #763
Conversation
should haveSubstring doesn't show diff between two texts, and with generated code being 500 lines or so it's impossible to find why assertion fails.
…generated classes).toDataFrame() workflow
koperagen
force-pushed
the
generate-data-classes
branch
2 times, most recently
from
f592180
to
7879438
Compare
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/CodeGenerationTests.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/CodeGenerationTests.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/MarkersExtractor.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/codeGen/MarkersExtractor.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Do we have an analogue of suggested printDataClassSchema from https://github.com/holgerbrandl/kdfutils?tab=readme-ov-file#data-frame-schema?
I could not understand this and find in tests in proposed PR, sorry
|
|
…eGen to org.jetbrains.kotlinx.dataframe.api Having to import this function in notebooks is bothersome. Api package is imported by default. Adding codeGen to default imports would add too much things.
Function is intended to be used together with either KSP or compiler plugin, so generated extension properties won't be needed
koperagen
force-pushed
the
generate-data-classes
branch
from
7879438
to
9296544
Compare
|
@koperagen could you add a page in our docs or chapter with simple description and small example? |
|
Let's do it later. I want to find a better form and place for it |
|
We could add documentation later, but in this case, please create a doc ticket for this, link to this issue and assign on your-self (because we need to extract some knowledge here and could not deliver without documentation new functionality) |
|
Generated sources will be updated after merging this PR. |
I recommend to review commits individually. First two were small changes made to improve debugging experience, and other two are separate features
Fixes #344