Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compiler plugin] Avoid throwing debugging exceptions in user projects because of false positives #788

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

koperagen
Copy link
Collaborator

In IDE compiler plugin constantly analyses the code as it's typed, so it can be in an incomplete state. So any invariant that we would expect and try to enforce with exception, can be broken. That's why plugin should not throw exceptions or only throw them in tests

@koperagen koperagen self-assigned this Jul 18, 2024
@koperagen koperagen force-pushed the compiler-plugin-exception-fixes branch from c1b02a1 to 3590f91 Compare July 18, 2024 12:17
@koperagen koperagen merged commit 0daccc8 into master Jul 18, 2024
3 checks passed
@Jolanrensen Jolanrensen added the Compiler plugin Anything related to the DataFrame Compiler Plugin label Aug 8, 2024
@koperagen koperagen deleted the compiler-plugin-exception-fixes branch August 26, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compiler plugin Anything related to the DataFrame Compiler Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants