Enforcing kotlinx datetime bias #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tc. Adding missing conversions
Jolanrensen
added
bug
koperagen
reviewed
Sep 2, 2024
| } | ||
|
|
||
| java.time.LocalDate::class -> convert<Long> { it.toLocalDate(defaultTimeZone).toJavaLocalDate() } | ||
| JavaLocalDate::class -> convert<Int> { it.toLong().toLocalDate(defaultTimeZone).toJavaLocalDate() } |
There was a problem hiding this comment.
It appears like Long converter was removed. Why?
There was a problem hiding this comment.
this is the when (fromClass) { Int::class -> } branch, not the Long branch :) it was in the wrong place
koperagen
reviewed
Sep 2, 2024
| @@ -243,29 +243,30 @@ internal class ArrowWriterImpl( | |||
| is TimeNanoVector -> | |||
| column.convertToLocalTime() | |||
| .forEachIndexed { i, value -> | |||
| value?.also { vector.set(i, value.toNanoOfDay()) } | |||
| value?.also { vector.set(i, value.toJavaLocalTime().toNanoOfDay()) } | |||
There was a problem hiding this comment.
is this conversion needed?
There was a problem hiding this comment.
actually, it isn't :) thanks
|
I wouldn't assign "bug" to this. Instead, something like "migration-needed" would be good. For user it will be a breaking change |
Jolanrensen
force-pushed
the
kotlinx.datetime
branch
from
1c3b3c7
to
3a447b7
Compare
|
Generated sources will be updated after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different parts of the library had different biases towards using Java's datetime libraries or Kotlin's.
Since DF is a Kotlin library, we should prefer Kotlin's.
This PR addresses that, while also filling in some missing conversions/parsers.