Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #1731

Closed
cromefire opened this issue Feb 4, 2021 · 2 comments
Closed

Dark mode #1731

cromefire opened this issue Feb 4, 2021 · 2 comments
Labels
enhancement An issue for a feature or an overall improvement

Comments

@cromefire
Copy link

Is your feature request related to a problem? Please describe
Some people may like a dark theme (the intelliJ IDEs have one for example, the the new kotlin docs too at far as I'm aware), to reduce the strain on their eyes, so I propose to add a dark theme to the generated docs.

Describe the solution you'd like
A dark theme can easily implemented using js and css.
I'd propose the use of a simple button and a bit of js glue that adds or removes a css class from body. persistence can be handled via local storage.
In addition the initial value could be set via media query (observable via js) with maybe an option for auto that reacts to media queries (for stuff like dark mode after sunset).

Describe alternatives you've considered
Dark reader works okay-ish. Some contrasts are not good, but most things are readable.

Additional context
I'd be willing to help here, especially with the js/button part, but some graphics need an update:
image
(all icons are SVGs so this might be relatively easy and even doable with my limited skills)

Icons are available from material for example.

@cromefire cromefire added the enhancement An issue for a feature or an overall improvement label Feb 4, 2021
@cromefire
Copy link
Author

I sady can't find where the web frontend is available/generated...

@yalishevant
Copy link

Solved in 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An issue for a feature or an overall improvement
Projects
None yet
Development

No branches or pull requests

2 participants