-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic dark mode #2591
Comments
This would be nice to have! If anyone wishes to contribute, I believe the code for enabling dark mode is here.
Not sure how to add a 3rd auto option, there's a single toggle button atm. Would you expect the button to have 3 states or would you rather see it in the configuration settings? I think if you open up Dokka for the first time, it could choose light/dark mode based on OS theme, and then if the person decides to switch it to something else - remember that choice. |
Not sure TBH. Apple documentations have a 3-state "chooser": Looks like Android documentation is light mode only. Our own docs do what you suggest below.
Makes sense, probably the easiest way to implement it and would work in the vast majority of use cases 👍 |
First time contributing here, I put in a PR which should do what you mentioned:
Please let me know what you think. |
Follow up from #1731
The dark mode is nice 👏 . Would be nice to have an "automatic mode" that detects the current OS setting. This seems to be possible. See this stackoverflow question for a possible implementation.
The dark mode would be a 3 way setting:
The text was updated successfully, but these errors were encountered: