Fix parsing of static imports in annotation params #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
requested changes
Aug 3, 2022
| import com.intellij.lang.jvm.annotation.JvmAnnotationAttributeValue | ||
|
|
||
| /* | ||
| * For some reason `PsiAnnotationConstantValue` is package private, |
There was a problem hiding this comment.
Can you use a public interface JvmAnnotationConstantValue instead of PsiAnnotationConstantValue?
There was a problem hiding this comment.
Wow, yeah, totally.
I was looking for something like this, but when you open up PsiAnnotationConstantValue and go to declaration of JvmAnnotationConstantValue from the signature - it goes to the kotlin-compiler artifact, where the interface is empty, so I thought there was no other way 🤦
Importing it seems to be fine though
vmishenev
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2580