Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gradle Enterprise #2641

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Enable Gradle Enterprise #2641

merged 4 commits into from
Aug 25, 2022

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Aug 24, 2022

@IgnatBeresnev
Copy link
Member

Hi! I see the appeal in gradle enterprise for investigating bugs when you need to share some details with another person, but then you could publish an individual build

Is there some great value to contributors and/or maintainers to publish every single build? What could be done with it, and what would we be missing if we don't do it?

My concern is that we won't need 99% of published scans, while it could make build times longer, especially when connection is poor

@Goooler
Copy link
Contributor Author

Goooler commented Aug 24, 2022

If necessary we can publish the build scan on CI only like this:
https://github.com/apache/groovy/blob/3405c7be6d64f462a76b6a864aecdbdcbbe80e89/gradle/build-scans.gradle#L20-L55

@IgnatBeresnev
Copy link
Member

if necessary we can publish the build scan on CI only like this

Oooh, yes, that would make me happy :) Certainly would not hurt

@Goooler
Copy link
Contributor Author

Goooler commented Aug 24, 2022

Copy link
Member

@vmishenev vmishenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for me, it is extremely useful. Thank you for contributing.

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IgnatBeresnev IgnatBeresnev merged commit 02b0c63 into Kotlin:master Aug 25, 2022
@Goooler Goooler deleted the ge branch August 25, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants