Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline @param tag key for more consistency #2643

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Aug 24, 2022

See #2576

Styling TBD

@@ -1038,7 +1056,7 @@ td.content {

@media print, screen and (min-width: 960px) {
.keyValue {
grid-template-columns: 25% 75%;
grid-template-columns: 20% 80%;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to 1.7.10 behaviour. It looks good if keyValue table is part of the main content, but first column takes too much space if parameters are within tabbed content (there's not much space as it is)

@IgnatBeresnev IgnatBeresnev mentioned this pull request Aug 24, 2022
@IgnatBeresnev IgnatBeresnev marked this pull request as ready for review August 29, 2022 11:09
@IgnatBeresnev
Copy link
Member Author

Researched making parameter names clickable (focus signature on click), and it seems a bit too complicated to implement, not sure it's worth the effort now.

The main problem is when you have multiple signatures on the same page and multiple param blocks, especially if you have 4 signatures and only 2 param blocks. Ideally we'd need to add anchor ids/tags to signatures for them to be focusable, and write some js code around it - preferably so that it can be reused by other components, so something universal.

If it becomes a usability problem where people expect param keys to be clickable links, it can be implemented, but I think it can be skipped for now to not overcomplicate things

@IgnatBeresnev IgnatBeresnev merged commit 56ff8f3 into master Sep 2, 2022
@IgnatBeresnev IgnatBeresnev deleted the underline-param-key branch September 2, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants