Fix TypeNotPresentException
in projects without KGP
#2890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from 0a09318#diff-127cb17801c64a32309502eaee33392ad749494ba8022bef47e8002359ea1b8eL17
Before, it was loading a specific java class, so it failed with
NoClassDefFoundError
that was caught, and we returned null.With Kotlin DSL,
findByType()
is trying to loadreified T
throughClass#getGenericSuperclass
, which throwsTypeNotPresentException
.We don't expect that
TypeNotPresentException
will be thrown, so it's not caught and the user project is failing withThis can be reproduced on projects that don't have KGP applied.