build: extracted UI components to ui-kit in plugin-base-frontend #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezinant
added
format: html
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
3 times, most recently
from
8b40b31
to
2cea11c
Compare
berezinant
changed the title
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
from
2cea11c
to
f3358eb
Compare
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
3 times, most recently
from
e93a272
to
6f84eb3
Compare
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
from
31ae203
to
0d26102
Compare
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
2 times, most recently
from
09863bf
to
303049d
Compare
berezinant
commented
Jun 14, 2024
Comment on lines
+37
to
+43
| return records.map((record) => { | ||
| return { | ||
| ...record, | ||
| template: <SearchResultRow searchResult={record} />, | ||
| } as Omit<OptionWithSearchResult, 'name'> & { name: unknown } as OptionWithHighlightComponent; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
some typing fixes that aren't pretty but it's better then ignoring
Comment on lines
-55
to
-56
| _showPopup(){ | ||
| if(this.props.shouldShowPopup){ |
There was a problem hiding this comment.
this turns out to be unused
Comment on lines
+17
to
+25
| const onChangeSelected = useCallback( | ||
| (selectItem: SelectItem<unknown> | null) => { | ||
| if (!selectItem) { | ||
| return; | ||
| } | ||
| const maybeOption: Option = selectItem as Option; | ||
| window.location.replace(`${(window as IWindow).pathToRoot}${maybeOption.location}?query=${maybeOption.name}`); | ||
| onSelected(maybeOption); | ||
| }, |
There was a problem hiding this comment.
another hack just to proceed with legacy code
| }; | ||
| })(); | ||
|
|
||
| export function initTabs() { |
There was a problem hiding this comment.
This is pretty much extracted from dokka-subprojects/plugin-base/src/main/resources/dokka/scripts/platform-content-handler.js
IgnatBeresnev
approved these changes
Jun 18, 2024
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
2 times, most recently
from
4b131b1
to
c884402
Compare
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
from
c884402
to
f4c8702
Compare
berezinant
force-pushed
the
refactor-3460-styles-processing
branch
from
f4c8702
to
16bd619
Compare
adam-enko
reviewed
Jul 29, 2024
Comment on lines
+42
to
+43
| **/node_modules | ||
| **/build |
There was a problem hiding this comment.
Belated nitpick: Are these excludes necessary?
build/ directories are already excluded on line 30, and node_modules/ is excluded specifically in dokka-subprojects/plugin-base-frontend/.gitignore
There was a problem hiding this comment.
thanks, it's really unnecessary, removed it in https://github.com/Kotlin/dokka/pull/3714/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#3460
#3461
#3462
The UI component is just a couple of js and css files which are conntected to the markup by bem, if possible
The assets (ts and scss) are compiled by webpack, the results are stored in plugin-base as plain files js and css (both minified and non-minified for the sake of possible customization by users) files and committed to the repo.