-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out JVM mapped methods #3694
Filter out JVM mapped methods #3694
Conversation
|
||
// this "grey" list does not exist in the compiler explicitly | ||
// this was made manually | ||
private val NOT_CONSIDER_METHOD_SIGNATURES: Set<String> = inJavaUtil( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be unreliable in the case of a new method in JVM.
FYI, integrations tests failed on TC. Also, it would be really nice to check the difference (and correctness) of produced HTML before and after this PR on kotlin-stdlib and https://github.com/Kotlin/kotlinx.collections.immutable before merging this PR |
e9393b0
to
35423fb
Compare
It was due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Would be really nice to know how it affects stdlib and immutable collections before merging.
dokka-subprojects/plugin-base/src/test/kotlin/transformers/JvmMappedMethodsFilterTest.kt
Outdated
Show resolved
Hide resolved
...rains/dokka/base/transformers/documentables/JvmMappedMethodsDocumentableFilterTransformer.kt
Outdated
Show resolved
Hide resolved
...rains/dokka/base/transformers/documentables/JvmMappedMethodsDocumentableFilterTransformer.kt
Show resolved
Hide resolved
b4f968e
to
53363f7
Compare
ffdc045
to
f7d7964
Compare
I have checked the PR on stdlib. Also, |
This is a short-term solution for #3542
The good news is that the generated documentation does not depend on a version of the JDK anymore