Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid configuration resolution error for v2 migration helper task #3950

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

adam-enko
Copy link
Member

@adam-enko adam-enko commented Dec 9, 2024

Fix error when running dokkaHtml task when v2 migration helpers are enabled.

Summary

The problem:

  • DGPv1 tasks contain automatic configuration for task inputs that cannot be disabled dynamically by V2.
  • When v2 registered the migration helpers, it uses the same task types to prevent breaking changes in buildscripts.
  • The task types automatically configured themselves using Configurations that v2 makes incompatible.

The solution:

  • Update the v1 tasks to lazily configure the input values.

Fix KT-72000

@adam-enko adam-enko self-assigned this Dec 9, 2024
@adam-enko adam-enko added the runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin label Dec 9, 2024
@adam-enko adam-enko added this to the Dokka 2.0.0 milestone Dec 9, 2024
@adam-enko adam-enko requested a review from whyoleg December 9, 2024 12:56
@adam-enko adam-enko marked this pull request as ready for review December 9, 2024 12:56
@adam-enko adam-enko requested a review from Tapchicoma December 10, 2024 09:12
@adam-enko adam-enko merged commit a2fe934 into master Dec 10, 2024
14 checks passed
@adam-enko adam-enko deleted the adam/fix/KT-72000-v2-dokkaHtml-migration branch December 10, 2024 09:58
@adam-enko adam-enko restored the adam/fix/KT-72000-v2-dokkaHtml-migration branch December 10, 2024 09:58
@adam-enko adam-enko deleted the adam/fix/KT-72000-v2-dokkaHtml-migration branch December 10, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner: Gradle plugin An issue/PR related to Dokka's Gradle plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants