Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented detection of Cocoapods installed via Homebrew #15

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Implemented detection of Cocoapods installed via Homebrew #15

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba2ba6a
[WIP] Cocoapods detection
arturm-hexagon Feb 20, 2022
4d85ca0
Implemented detection of Cocoapods installed via Homebrew
arturm-hexagon Feb 20, 2022
3651b0e
Removed non-existing parameter, thus made the branch compilable (oops)
amatsegor Feb 21, 2022
7e931c3
Cocoapods via Homebrew: refactored as per PR comments
Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 34 additions & 14 deletions kdoctor/src/commonMain/kotlin/org/jetbrains/kotlin/doctor/diagnostics/CocoapodsDiagnostic.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import org.jetbrains.kotlin.doctor.entity.Application
import org.jetbrains.kotlin.doctor.entity.System
import org.jetbrains.kotlin.doctor.entity.Version
import org.jetbrains.kotlin.doctor.entity.execute
import org.jetbrains.kotlin.doctor.entity.getEnvVar

class CocoapodsDiagnostic : Diagnostic("Cocoapods") {
override fun runChecks(): List<Message> {
Expand Down Expand Up @@ -53,34 +52,55 @@ class CocoapodsDiagnostic : Diagnostic("Cocoapods") {
val gems = Application("ruby gems", Version(rubyGemsVersion))
messages.addSuccess("${gems.name} (${gems.version})")

val gemList = System.execute("gem", "list", "--local", "cocoapods").output
val cocoapodsGems = gemList?.split("\n")?.mapNotNull {
val nameAndVersion = it.split(" ", limit = 2)
val name = nameAndVersion.firstOrNull() ?: return@mapNotNull null
val versionString = nameAndVersion.lastOrNull()?.trim('(', ')')
val version = if (versionString != null) Version(versionString) else Version.unknown
Application(name, version)
var cocoapods: Application? = null
val cocoapodsVersionOutput = System.execute("pod", "--version").output
if (cocoapodsVersionOutput != null) {
val cocoapodsVersion = Version(cocoapodsVersionOutput)
cocoapods = Application("cocoapods", cocoapodsVersion)
}

val cocoapods = cocoapodsGems?.firstOrNull { it.name == "cocoapods" }
if (cocoapods == null) {
//check if installed via brew but not linked to /usr/bin
val cocoapodsBrewInstallation = System.execute("brew", "list", "cocoapods", "--versions").output
if (cocoapodsBrewInstallation?.isNotBlank() == true) {
messages.addFailure(
"Cocoapods are installed via Homebrew but not linked to /usr/local/bin",
"Execute 'brew link --overwrite cocoapods'"
)
} else {
messages.addFailure(
"cocoapods not found",
"Get cocoapods from https://guides.cocoapods.org/using/getting-started.html#installation"
)
}
return messages
} else if (cocoapods.version < Version(1, 8, 0)) {
messages.addFailure(
"cocoapods not found",
"Get cocoapods from https://guides.cocoapods.org/using/getting-started.html#installation"
"cocoapods version ${cocoapods.version.version} is outdated",
"Update your cocoapods installation to the latest available version"
)
return messages
}

messages.addSuccess("${cocoapods.name} (${cocoapods.version})")

val cocoapodsGenerate = cocoapodsGems.firstOrNull { it.name == "cocoapods-generate" }
var cocoapodsGenerate: Application? = null
val cocoapodsGenerateName = "cocoapods-generate"
val plugins = System.execute("pod", "plugins", "installed", "--no-ansi").output
val cocoaPodsGenerateEntry = plugins?.lines()?.find { it.contains(cocoapodsGenerateName) }
if (cocoaPodsGenerateEntry != null) {
val version = cocoaPodsGenerateEntry.split(":").lastOrNull()?.let { Version(it.trim()) }
if (version != null) {
cocoapodsGenerate = Application(cocoapodsGenerateName, version)
}
}

if (cocoapodsGenerate == null) {
messages.addFailure(
"cocoapods-generate plugin not found",
"Get cocoapods-generate from https://github.com/square/cocoapods-generate#installation"
)
return messages
}

if (cocoapodsGenerate.version < Version(2, 2, 2)) {
messages.addFailure(
"Cocoapods-generate version ${cocoapodsGenerate.version} is not supported",
Expand Down