Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved cache in message_type serializer to ConcurrentHashMap #404

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

jbaron
Copy link
Contributor

@jbaron jbaron commented Mar 14, 2023

Moved cache in message_type serializer to ConcurrentHashMap to avoid concurrent modification exceptions. ConcurrentHashMap seems a good fit due to low overhead when reading from the map (which is the main purpose of a cache).

Updated both MessageTypeSerializer and DetailsLevelSerializer.

@jbaron jbaron mentioned this pull request Mar 14, 2023
@jbaron
Copy link
Contributor Author

jbaron commented Mar 15, 2023

Test were running fine on my laptop, so not sure what went wrong in the TeamCity build. I cannot access details of what went wrong, since it requires a jetbrains email account.

@ileasile
Copy link
Member

Thank you for PR! Please run Reformat.. run configuration, I think there's an issue with imports order. Also, run :check instead of :test, it also checks formatting and Readme consistency. And it's actually run on TC

@ileasile ileasile merged commit f62beec into Kotlin:master Mar 16, 2023
@jbaron
Copy link
Contributor Author

jbaron commented Mar 16, 2023

@ileasile thanks for fixing it, not sure what the logic behind "Imports must be ordered in lexicographic order" exactly implies. It is clearly not as simple as alphabetically ordered.

@ileasile
Copy link
Member

Yes, it's some order that our formatter respects :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants