Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After applying atomicfu plugin to a project with Java sources corresponding classes are missing #388

Closed
fzhinkin opened this issue Dec 27, 2023 · 1 comment
Closed

After applying atomicfu plugin to a project with Java sources corresponding classes are missing #388

fzhinkin opened this issue Dec 27, 2023 · 1 comment
Assignees
@mvicsokolova
Labels
bug regression Major regressions that were not caught in advance and were discovered after the release

Comments

@fzhinkin
Copy link
Contributor

Based on #384 (comment)

If a project contains both Kotlin and Java sources, application of the atomicfu plugin leads to Java classes being lost.

Here's a reproducer: https://github.com/fzhinkin/atomicfu-issues-with-java-sources

Everything works fine with atomicfu version below 0.21.0.
@fzhinkin fzhinkin added bug regression Major regressions that were not caught in advance and were discovered after the release labels Dec 27, 2023
@mvicsokolova
Copy link
Collaborator

Thank you for the reproducer 🙏🏻

mvicsokolova added a commit that referenced this issue Jan 17, 2024
@mvicsokolova
Fixup: Added Java classes to the jvm-sample to test #388.
2ab3902 
Without the fix from the previous commit, jvm-sample build would fail with "Unresolved reference: JavaClass".

Fixes #388
mvicsokolova added a commit that referenced this issue Jan 18, 2024
@mvicsokolova
Add all sources to the transformed directories
15649b8 
Fixes #388
@mvicsokolova mvicsokolova mentioned this issue Jan 18, 2024
Merged
mvicsokolova added a commit that referenced this issue Jan 22, 2024
@mvicsokolova @Tapchicoma
Add all sources to the transformed directory (#394)
e3cb148 
* Add all sources to the transformed directories.

Fixes #388

Co-authored-by: Yahor Berdnikau <yahor.berdnikau@jetbrains.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvicsokolova mvicsokolova

Labels
bug regression Major regressions that were not caught in advance and were discovered after the release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzhinkin @mvicsokolova