Alternative solution how to add compiler plugin dependency to the project #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
reviewed
Dec 21, 2023
|
fzhinkin
requested changes
Dec 21, 2023
integration-testing/examples/plugin-order-bug/gradle.properties
Outdated
Show resolved
Hide resolved
mvicsokolova
commented
Dec 21, 2023
| @@ -17,4 +18,14 @@ class PluginOrderBugTest { | |||
| val buildResult = pluginOrderBugProject.cleanAndBuild() | |||
| assertTrue(buildResult.isSuccessful, buildResult.output) | |||
| } | |||
|
|
|||
| @Test | |||
| fun testResolvedCompilerPluginDependency() { | |||
There was a problem hiding this comment.
I've added some check that there is org.jetbrains.kotlin:atomicfu:1.9.20 dependency in the project classpath.
In the buildEnvironment we can also find the resolution string:
org.jetbrains.kotlin:atomicfu:1.6.20 -> 1.9.20
but probably just checking for the kotlin version is enough
There was a problem hiding this comment.
Thanks to covering such a scenario!
…-plugin. Do not require to add it manually. Fixes #384
…adle-plugin tests, as those tests are already removed
…at it would be resolved to the latest version present on the user side
…ed for Native targets. It adds kotlin-stdlib dependency as an implementation dependency, though it marks it's version as prefered to avoid resolution in the user project.
|
Rebased on the latest develop with increased Metaspace |
mvicsokolova
force-pushed
the
wildcard-dependency
branch
from
930c063 to
e6206c5
Compare
|
Maybe we can postpone solution of the problem with the compileOnly atomicfu dependency in Native targets for now? Though the resolution of this warning for kotlin-stdlib dependency seems ok for now. |
fzhinkin
approved these changes
Jan 15, 2024
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a transitive dependency to the compiler plugin in atomicfu-gradle-plugin.
Do not require to add it manually.
Problem: not sure that compiler plugin dependency will be resolved correctly on the user side.