Enable cache-redirector #453
Conversation
...ting/src/functionalTest/kotlin/kotlinx.atomicfu.gradle.plugin.test/framework/runner/Utils.kt
Outdated
Show resolved
Hide resolved
dkrasnoff
force-pushed
the
build-config/cache-redirector
branch
from
21d0232
to
d8b9a77
Compare
| } | ||
| } | ||
|
|
||
| pluginManagement.repositories.redirect() |
There was a problem hiding this comment.
@adam-enko honestly say, I still don't understand, why do you suggest to move it to gradle dir. It looks like a real settings plugin, which should be applied directly to settings.gradle.kts.
I would suggest not to move it.
There was a problem hiding this comment.
Well, because it's not a real settings plugin :) It's applied as a file-based script plugin in build-settings-logic/settings.gradle.kts and in all of the integration tests.
While technically it can be both a file-based and pre-compiled script plugin, it's a little odd. I also don't like that it's easy to accidentally break the the plugin by using a utility function from Utils.kt.
That said, if it works, it works. I'm not going to block the PR because of it.
| .normalize() | ||
| .toFile() | ||
|
|
||
| val gradleDir = resolve("gradle").also { it.createDirectories() } |
There was a problem hiding this comment.
| val gradleDir = resolve("gradle").also { it.createDirectories() } | |
| val gradleDir = resolve("gradle").createDirectories() |
nitpick: createDirectories() returns the same value, so also {} could be removed.
There was a problem hiding this comment.
moved this change to #460
dkrasnoff
force-pushed
the
build-config/cache-redirector
branch
from
d8b9a77
to
e0a3ee3
Compare
Cache-redirector works like CDN for JB builds.
The major part of the code was copy-stolen from kotlin repo's cache-redirector (it worth to add to a shared build-scripts for JB, when such repository will be exist).
In this PR I also removed duplicated properties for setting koltin version and custom repository URL according to our checklist #421