Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support debug build configuration for K/N #189

Closed
fzhinkin opened this issue Feb 15, 2024 · 1 comment · Fixed by #225
Closed

Support debug build configuration for K/N #189

fzhinkin opened this issue Feb 15, 2024 · 1 comment · Fixed by #225
Assignees
Labels
enhancement New feature or request

Comments

@fzhinkin
Copy link
Contributor

Currently, kotlinx-benchmark implicitly use release configuration for K/N builds. That's absolutely sane and reasonable default. However, in some cases (like this), performance need to be collected and validated for debug builds.

It would be nice to have an option to choose K/N build configuration, with release still being a default.

@fzhinkin
Copy link
Contributor Author

Probably, the build configuration could be configured when a benchmarking target is declared. Something like this:

benchmark {
    targets {
        register("macosArm64") {
             this as NativeBenchmarkTarget
             buildType = NativeBuildType.DEBUG
             // or simply, debug = true
        }
    }
}

@qurbonzoda qurbonzoda added the enhancement New feature or request label Feb 19, 2024
@PavelPunegov PavelPunegov self-assigned this Jun 5, 2024
PavelPunegov added a commit that referenced this issue Jun 6, 2024
Adds a build type setting to the NativeBenchmarkTarget to provide the ability to test debug builds.
Fixes #189
qurbonzoda pushed a commit that referenced this issue Jun 10, 2024
Adds a build type setting to the NativeBenchmarkTarget to provide the ability to test debug builds.
Fixes #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants