Add a guide to creating a separate module for benchmarks #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
requested changes
Dec 27, 2023
fzhinkin
approved these changes
Jan 4, 2024
Goooler
reviewed
Jan 11, 2024
| 3. **Register Benchmark Source Set** | ||
|
|
||
| Register your benchmark source set. This informs the kotlinx-benchmark tool | ||
| that benchmarks reside within this source set and need to be executed accordingly. |
There was a problem hiding this comment.
Suggested change
| that benchmarks reside within this source set and need to be executed accordingly. | |
| about benchmarks reside within this source set and need to be executed accordingly. |
There was a problem hiding this comment.
I am not sure if the change is grammatically correct.
I surfed the internet, and it seems both prepositions are fine to use in this case. |
Merged
qurbonzoda
force-pushed
the
add-tasks-overview-guide
branch
from
5ef9a3f
to
0e9ce88
Compare
… docs/separate-benchmark-module.md Co-authored-by: Filipp Zhinkin <filipp.zhinkin@gmail.com> Co-authored-by: Zongle Wang <wangzongler@gmail.com>
qurbonzoda
force-pushed
the
add-separate-benchmark-module
branch
from
90c20ae
to
d615cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #170
The changes were developed within GSoC 2023 program by our mentee @wldeh.