Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure project to allow for splitting up Gradle plugin #228

Closed
wants to merge 1 commit into from

Conversation

adam-enko
Copy link
Member

  • Convert buildSrc to build-logic, so utils/conventions can be re-used in other included builds.
  • Introduce convention plugins for common config, and publishing (replacing kotlinx.team.infra, which is not compatible with modern Gradle approaches)
  • Workaround Gradle issue with running tasks in included builds Support invoking task selectors on included builds gradle/gradle#22335
  • Use centralised repository definitions
  • Rename subprojects to be more aligned.
  • Convert 'examples' to included build, so that it can more easily depend on the 'core' projects
  • Group Benchmarks runtime/generator/plugin repositories into a single included build
  • Update Gradle to 8.8

- Convert buildSrc to build-logic, so utils/conventions can be re-used in other included builds.
- Introduce convention plugins for common config, and publishing (replacing kotlinx.team.infra, which is not compatible with modern Gradle approaches)
- Workaround Gradle issue with running tasks in included builds gradle/gradle#22335
- Use centralised repository definitions
- Rename subprojects to be more aligned.
- Convert 'examples' to included build, so that it can more easily depend on the 'core' projects
- Group Benchmarks runtime/generator/plugin repositories into a single included build
- Update Gradle to 8.8
@adam-enko
Copy link
Member Author

This PR is no longer needed. Instead of splitting up the project, the Worker API was added in-place. It would be good to revisit this in the future though. Splitting out the generation code would improve code organisation, and prevent using compile-only dependencies in plugin config.

@adam-enko adam-enko closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant