Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses wrong name for kotlinx-serialization module with legacy compiler #118

Closed
ethanmdavidson opened this issue May 18, 2021 · 2 comments
Closed

uses wrong name for kotlinx-serialization module with legacy compiler #118

ethanmdavidson opened this issue May 18, 2021 · 2 comments

Comments

@ethanmdavidson
Copy link

ethanmdavidson commented May 18, 2021 •
edited
Loading

repo demonstrating issue: https://github.com/ethanmdavidson/serializationNameBug

When using the legacy compiler, kotlinx-datetime uses an old name when referencing kotlinx-serialization: 'kotlinx-serialization-kotlinx-serialization-core-jsLegacy' instead of 'kotlinx-serialization-kotlinx-serialization-core-js-legacy'.

May be related to https://youtrack.jetbrains.com/issue/KT-46598

I think it might be fixed by simply upgrading kotlinx.serialization to 1.2.1 (latest version)
@dkhalanskyjb
Copy link
Collaborator

Thanks for raising this, your reproducer is great! Yes, either rebuilding the datetime library with dependency on kotlinx.serialization 1.2.1 or using kotlinx.serialization 1.1.0 does fix the issue. This problem is unexpected, we will be looking into it.

@set321go
Copy link

set321go commented May 19, 2021 •
edited
Loading

It looks like this is the cause https://youtrack.jetbrains.com/issue/KT-43237 so my interpretation is that there is now an incompatibility between modules published with 1.4 and 1.5

@dkhalanskyjb dkhalanskyjb mentioned this issue May 25, 2021
Closed
dkhalanskyjb added a commit that referenced this issue May 25, 2021
@dkhalanskyjb
Upgrade the Kotlin version
b4128f4 
* This fixes the incompatibility with the newer serialization
  versions.
* Upgraded the version of kotlinx.serialization.
* watchosX64 target is added.

Fixes #118
dkhalanskyjb added a commit that referenced this issue May 25, 2021
@dkhalanskyjb
Upgrade the kotlinx-serialization version
78fe53a 
* This fixes the incompatibility with the newer serialization
  versions.
* watchosX64 target can now be added.

Fixes #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@set321go @ethanmdavidson @dkhalanskyjb