Remove extra hierarchy level in DateTimeUnit sealed class inheritors #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
approved these changes
Sep 1, 2021
| } | ||
| @Suppress("TOPLEVEL_TYPEALIASES_ONLY") | ||
| @Deprecated("Use DateTimeUnit.DayBased", ReplaceWith("DateTimeUnit.DayBased", "kotlinx.datetime.DateTimeUnit")) | ||
| public typealias DayBased = DateTimeUnit.DayBased |
There was a problem hiding this comment.
I seem to remember that these type aliases didn't work in some regard, right? I tried to use them and everything worked fine. Does this mean that you found a solution to that issue? If not, Deprecated should probably be with the DeprecationLevel.ERROR.
There was a problem hiding this comment.
As I recall, they caused problems when used from inside of the the inheritors of DateTimeUnit classDateBased class. That's why I had to prefix the affected types with DateTimeUnit. — to avoid resolving to type aliases there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.