Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the KDoc #367

Merged
merged 35 commits into from
May 13, 2024
Merged

Improve the KDoc #367

merged 35 commits into from
May 13, 2024

Commits on Apr 29, 2024

  1. Improve the KDoc 

    Fixes #347
    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b6a6338 View commit details
    Browse the repository at this point in the history

  2. Fix typos and small mistakes

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0a7298e View commit details
    Browse the repository at this point in the history

  3. Don't hyphenate ISO 8601 when used as a compound adjective

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e076439 View commit details
    Browse the repository at this point in the history

  4. Implement the first pack of fixes after the review

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ca9c739 View commit details
    Browse the repository at this point in the history

  5. The second pack of changes

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c6dd47f View commit details
    Browse the repository at this point in the history

  6. Add samples for TimeZone, UtcOffset, and Month

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1a4b0f9 View commit details
    Browse the repository at this point in the history

  7. WIP: add samples for LocalTime

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6883ffb View commit details
    Browse the repository at this point in the history

  8. WIP: add samples for some formatting APIs

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    671ee59 View commit details
    Browse the repository at this point in the history

  9. More samples

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bca9eab View commit details
    Browse the repository at this point in the history

  10. Add samples for format builders

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ba55ab6 View commit details
    Browse the repository at this point in the history

  11. Samples for Date(Time)Period and Clock

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    85ab102 View commit details
    Browse the repository at this point in the history

  12. fixup

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cccad01 View commit details
    Browse the repository at this point in the history

  13. More samples; only LocalDate and Instant left

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f3d4653 View commit details
    Browse the repository at this point in the history

  14. Samples for LocalDate

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    77aff41 View commit details
    Browse the repository at this point in the history

  15. Finish adding samples

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d70657b View commit details
    Browse the repository at this point in the history

  16. Address the reviews

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3c956e0 View commit details
    Browse the repository at this point in the history

  17. Try to find the edge cases that work across platforms

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    788285c View commit details
    Browse the repository at this point in the history

  18. reword

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    60ed765 View commit details
    Browse the repository at this point in the history

  19. Update core/common/src/DateTimeUnit.kt 

    Co-authored-by: ilya-g <ilya.gorbunov@jetbrains.com>
    @dkhalanskyjb @ilya-g
    dkhalanskyjb and ilya-g committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fd8be7d View commit details
    Browse the repository at this point in the history

  20. Address the comments

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1302b7e View commit details
    Browse the repository at this point in the history

  21. Clarify setting DateTimeComponents.month

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8f73a08 View commit details
    Browse the repository at this point in the history

  22. Provide a one-line description for every sample

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    33a3717 View commit details
    Browse the repository at this point in the history

  23. More additions according to the reviews

    @dkhalanskyjb
    dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a2af2de View commit details
    Browse the repository at this point in the history

  24. feat: new docs review

    @danil-pavlov @dkhalanskyjb
    danil-pavlov authored and dkhalanskyjb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f7878af View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Mention the relevant parts of ISO 8601 when describing formats

    @dkhalanskyjb
    dkhalanskyjb committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    63644e6 View commit details
    Browse the repository at this point in the history

  2. Incorporate some more proofreading results 

    See #386
    @dkhalanskyjb
    dkhalanskyjb committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e6b758e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Address the review

    @dkhalanskyjb
    dkhalanskyjb committed May 1, 2024
    Configuration menu
    Copy the full SHA
    517ae7a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Address the review

    @dkhalanskyjb
    dkhalanskyjb committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f45e493 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. ~fixup

    @dkhalanskyjb
    dkhalanskyjb committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8a0e356 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Remove separate samples for Long overloads (plus a small fixup)

    @dkhalanskyjb
    dkhalanskyjb committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f70e422 View commit details
    Browse the repository at this point in the history

  2. Use yyyy instead of uuuu in the Unicode pattern sample

    @dkhalanskyjb
    dkhalanskyjb committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6c1423a View commit details
    Browse the repository at this point in the history

  3. Use Instant.fromEpochSeconds in samples more

    @dkhalanskyjb
    dkhalanskyjb committed May 10, 2024
    Configuration menu
    Copy the full SHA
    fa59e05 View commit details
    Browse the repository at this point in the history

  4. Fix a broken sample reference

    @dkhalanskyjb
    dkhalanskyjb committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a529d44 View commit details
    Browse the repository at this point in the history

  5. Fix broken table rendering

    @dkhalanskyjb
    dkhalanskyjb committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a0a1335 View commit details
    Browse the repository at this point in the history

  6. Properly display samples in Dokka

    @dkhalanskyjb
    dkhalanskyjb committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8851274 View commit details
    Browse the repository at this point in the history