No longer make Month and DayOfWeek type aliases on the JVM #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
non-type-alias-enums
branch
from
52dac5a
to
2e1c4f6
Compare
ilya-g
approved these changes
Apr 19, 2024
|
I actually don't remember us discussing this change. We mentioned this issue recently while discussing UUIDs and whether to make them type aliases on the JVM. If you have doubts about this change, we can hold a meeting. What led me to go and implement this is that |
|
Yes, there are some arguments for this change, like exhaustiveness of matching over expected enum entries and being able to provide companion for static extensions (though these shortcomings will be eventually fixed in Kotlin). On the other hand, this is a binary breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96