Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic filesystems support for Wasm: reuse JS implementation for wasmJs target #256

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

fzhinkin
Copy link
Collaborator

@fzhinkin fzhinkin commented Feb 6, 2024

This PR consists of the first patch bringing basic filesystem support to Wasm targets:

  • splits the single Wasm source set into wasmJs and wasmWasi;
  • creates a separate source set with nodeJs-filesystem implementation shared between js and wasmJs targets.

@fzhinkin fzhinkin marked this pull request as ready for review February 6, 2024 16:11
@fzhinkin
Copy link
Collaborator Author

fzhinkin commented Feb 6, 2024

the first patch

The second part will be about wasmWasi :)

@lppedd
Copy link
Contributor

lppedd commented Feb 6, 2024

Nice!

@goncalossilva you might want to use this instead of your custom implementation for JS/WASM in kotlinx-resources

@fzhinkin fzhinkin merged commit 54914dc into develop Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants