[PR 5/5] Hide Segment::data #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
force-pushed
the
bulk-api-part-3
branch
from
1855228
to
0a163a5
Compare
fzhinkin
force-pushed
the
bulk-api-part-4
branch
from
767a2c4
to
2268737
Compare
shanshin
reviewed
Jun 21, 2024
| val v = ( | ||
| data[pos++] and 0xffL shl 56 | ||
| or (data[pos++] and 0xffL shl 48) | ||
| or (data[pos++] and 0xffL shl 40) |
There was a problem hiding this comment.
Maybe it's paranoia, but does it work at the same speed as
or (data[pos + 1] and 0xffL shl 40)
?
(there is no frequent updating of the field value)
There was a problem hiding this comment.
pos here is a local variable defined few lines above, so the field will be updated only once, after all reads are done.
Anyway, I'll re-check how it works with explicit offsets and immutable base, the last time I tested it, there was no significant difference.
shanshin
approved these changes
Jul 1, 2024
fzhinkin
force-pushed
the
bulk-api-part-3
branch
from
23aaaab
to
0a86a46
Compare
fzhinkin
force-pushed
the
bulk-api-part-4
branch
from
13703b7
to
c644452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concludes unsafe-API-related changes by hiding the
Segment::data.The change itself has nothing to do with unsafe API as it is now but ensures that direct internal data won't leak into the codebase.
The latter unlocks features like #331 and #239