-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koverGenerateArtifact task generates a cacheable report that contains absolute path #440
Comments
Also, here is a workaround in the meantime for anyone facing the same issue:
|
One more thought on this, @shanshin do you think this task should be cacheable? It seems like it's a really fast one generating a small file that might be faster to be run than to be pulled from a remote cache. |
I have already prepared a fix. In any case, using absolute paths was originally a bad idea.
I'm not sure that the difference will be significant, but if you try it on yourself, it will be useful. Since we do not have statistics on the use of the remote cache, therefore, by default we assume that the local cache is used, and for special cases, it is possible to disable caching. |
Awesome! Thank you. When can we expect a fix for this one? 0.7.4?
I can give you data on this once we have a fix (0.7.4). I took a quick look at what this task does and it looks like it's only writing a few strings (file paths) to a file. I can guarantee you this is not worth caching due to the extremely low amount of computation. Even copy tasks are not considered worth caching according to Gradle: https://docs.gradle.org/current/userguide/build_cache.html#sec:task_output_caching_disabled_by_default Note that not making it cacheable doesn't mean subsequent tasks (tasks depending on |
Optimistically, |
Describe the bug
koverGenerateArtifact
task generates a report that contains absolute paths. That task is cacheable which means that subsequent builds pulling from the cache will get the same task output. The problem is that absolute paths are not the same on different machines, leading to subsequent tasks (e.g. koverXmlReport) to process invalid paths on subsequent builds/machines and as a result generates an empty reportExpected behavior
koverGenerateArtifact
should generate the content of its output as relative paths to the root of the project. This should be an easy fix.Reports
Example of the output file from koverGenerateArtifact stored in our build cache:
The text was updated successfully, but these errors were encountered: