Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compile dependency to Kover Features in Kover Gradle Plugin #567

Closed
shanshin opened this issue Mar 18, 2024 · 1 comment · Fixed by #574
Closed

Use compile dependency to Kover Features in Kover Gradle Plugin #567

shanshin opened this issue Mar 18, 2024 · 1 comment · Fixed by #574
Assignees
@shanshin
Labels
Feature Feature request issue type S: ready for release Status: merged in the main branch

Comments

@shanshin
Copy link
Collaborator

Since the version of the aggregator and report generator has been enshrined in the Kover Gradle Plugin for a long time, it makes no sense to use dynamic classpath of and classloader isolations in Gradle Workers.

We can use Kover Features as a compile dependency and use its API.

Steps

  • extract all functions to generate reports (including validation) to Kover Features artifact, create own unified api for this
  • add compile dependency on Kover Features
  • replace all calls of intellij-reporter with calls to Kover Features
  • remove the use of Gradle Workers
  • remove all intellij dependencies from Kover Gradle Plugin

This change can also eliminate the error with access to Freemarker template inside Gradle Worker, and simplify the implementation of warn on verification error.
@shanshin shanshin added Feature Feature request issue type S: untriaged Status: issue reported but unprocessed labels Mar 18, 2024
@shanshin shanshin self-assigned this Mar 18, 2024
shanshin added a commit that referenced this issue Mar 21, 2024
@shanshin
Used compile dependency to Kover Features in Kover Gradle Plugin
648e614 
Since the version of the aggregator and report generator has been enshrined in the Kover Gradle Plugin for a long time, it makes no sense to use dynamic classpath of and classloader isolations in Gradle Workers.

We can use Kover Features as a compile dependency and use its API.

This change can also eliminate the error with access to Freemarker template inside Gradle Worker, and simplify the implementation of warn on verification error.

Resolves #567
@shanshin shanshin mentioned this issue Mar 21, 2024
Merged
shanshin added a commit that referenced this issue Mar 27, 2024
@shanshin
Used compile dependency to Kover Features in Kover Gradle Plugin
8af377c 
Since the version of the aggregator and report generator has been enshrined in the Kover Gradle Plugin for a long time, it makes no sense to use dynamic classpath of and classloader isolations in Gradle Workers.

We can use Kover Features as a compile dependency and use its API.

This change can also eliminate the error with access to Freemarker template inside Gradle Worker, and simplify the implementation of warn on verification error.
It also makes it easier to write a Maven plugin, because it puts all the logic in a separate artifact.

Resolves #567
PR #574
@shanshin shanshin added S: ready for release Status: merged in the main branch and removed S: untriaged Status: issue reported but unprocessed labels Mar 28, 2024
@shanshin shanshin reopened this Mar 28, 2024
@shanshin
Copy link
Collaborator Author

Implemented in 0.8.0-Beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Feature Feature request issue type S: ready for release Status: merged in the main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Used compile dependency to Kover Features in Kover Gradle Plugin Kotlin/kotlinx-kover
1 participant
@shanshin