Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mistake in the guide "Connecting the JVM agent" #660

Closed
Mike-Wazovsky opened this issue Jul 30, 2024 · 2 comments
Closed

A mistake in the guide "Connecting the JVM agent" #660

Mike-Wazovsky opened this issue Jul 30, 2024 · 2 comments
Assignees
Labels
Bug Bug issue type S: untriaged Status: issue reported but unprocessed

Comments

@Mike-Wazovsky
Copy link

I was reproducing the following guide:
https://github.com/Kotlin/kotlinx-kover/blob/main/kover-jvm-agent/docs/index.md

Add an argument to the java application startup command -javaagent:<path_to_agent_jar>=file:<path_to_settings_file>. Example of an application launch command java -jar application.jar -javaagent:/opt/kover-jvm-agent-0.8.3.jar=file:/tmp/agent.args.

Here is shown a wrong example. -javaagent parameter has to be stated before -jar.

So the example should possibly look like this: java -javaagent:/opt/kover-jvm-agent-0.8.3.jar=file:/tmp/agent.args -jar application.jar

In the variation presented in the guide, the agent does not connect and does not warn the user about it

@Mike-Wazovsky Mike-Wazovsky added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels Jul 30, 2024
@shanshin
Copy link
Collaborator

Indeed, my bad

shanshin added a commit that referenced this issue Jul 30, 2024
@shanshin
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug issue type S: untriaged Status: issue reported but unprocessed
Projects
None yet
Development

No branches or pull requests

2 participants