Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSL v4 prototype #519

Merged
merged 1 commit into from
Feb 19, 2024
Merged

DSL v4 prototype #519

merged 1 commit into from
Feb 19, 2024

Conversation

shanshin
Copy link
Collaborator

@shanshin shanshin commented Dec 11, 2023 •
edited
Loading

No description provided.

@shanshin shanshin requested a review from sandwwraith December 11, 2023 15:22
@shanshin shanshin marked this pull request as ready for review December 18, 2023 11:10
sandwwraith
sandwwraith reviewed Dec 20, 2023
View reviewed changes
kover-gradle-plugin/examples/android/variantUsage/app/build.gradle.kts Outdated Show resolved Hide resolved
...ionalTest/kotlin/kotlinx/kover/gradle/plugin/test/functional/framework/mirroring/Invoking.kt Outdated Show resolved Hide resolved
...ionalTest/kotlin/kotlinx/kover/gradle/plugin/test/functional/framework/mirroring/Invoking.kt Outdated Show resolved Hide resolved
...Test/kotlin/kotlinx/kover/gradle/plugin/test/functional/framework/mirroring/MirroringTest.kt Outdated Show resolved Hide resolved
...n/src/main/kotlin/kotlinx/kover/gradle/plugin/appliers/artifacts/AbstractVariantArtifacts.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverNames.kt Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverNames.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/internal/ReportsImpl.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/tools/CoverageTool.kt Outdated Show resolved Hide resolved
sandwwraith
sandwwraith requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mainly reviewed docs and API without going deep into new artifacts, changes in locators and tasks.

docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVariantConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/internal/VariantsImpl.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/internal/VariantsImpl.kt Outdated Show resolved Hide resolved
@shanshin shanshin requested a review from sandwwraith February 5, 2024 11:45
sandwwraith
sandwwraith reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have questions for API anymore, but some declarations are still undocumented. Also, I think it would be reasonable to explain most common scenarios in first chapter of migration guide instead of vaguely mentioning that some settings changed blocks.

...onalTest/kotlin/kotlinx/kover/gradle/plugin/test/functional/cases/ConfigurationOrderTests.kt Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
kover-gradle-plugin/examples/android/flavors/app/build.gradle.kts Show resolved Hide resolved
kover-gradle-plugin/examples/android/multiplatform/app/build.gradle.kts Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverExtension.kt Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVariantConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVariantConfig.kt Show resolved Hide resolved
@shanshin shanshin requested a review from sandwwraith February 7, 2024 17:57
sandwwraith
sandwwraith reviewed Feb 8, 2024
View reviewed changes
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
docs/gradle-plugin/migrations/migration-to-0.8.0.md Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverReportConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVariantConfig.kt Outdated Show resolved Hide resolved
kover-gradle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverVariantConfig.kt Outdated Show resolved Hide resolved
@shanshin shanshin requested a review from sandwwraith February 8, 2024 20:28
@shanshin shanshin requested a review from sandwwraith February 9, 2024 12:48
@hamada147
Copy link

Excuse me, but when do you plan to merge this PR?!

@shanshin
Copy link
Collaborator Author

@hamada147, next week.
This will be a Beta release

@shanshin shanshin force-pushed the main branch 8 times, most recently from 714c7f2 to 0575a68 Compare February 17, 2024 22:14
@shanshin
Implemented Kover Gradle Plugin DSL v4
b5903d3 
- blocks kover and koverReports are merged
- added possibility of lazy configuration of Kover extensions
- removed the concept of default reports
- added the ability to create custom report variants
- Created interfaces for Kover tasks

Resolves #461
Resolves #410
Resolves #462
Resolves #463
Resolves #338
@shanshin shanshin merged commit e49c6a6 into main Feb 19, 2024
1 check passed
@shanshin shanshin deleted the dsl-rev4 branch February 19, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanshin @hamada147 @sandwwraith