Fixed JaCoCo error: Can't add different class with same name #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Commit says that 'MainActivity.kt' is moved from kover-gradle-plugin/src/functionalTest/templates/builds/android-common-verify/app/src/main/java/kotlinx/kover/test/android/MainActivity.kt. And indeed there is no more MainActivity in android-common-verify. Is this intended?
|
Yes, it's ok, in most cases Activity is useless, and isn't tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now duplicate classes are added to the JaCoCo report only once - this behavior copies the behavior from Kover report generator
Resolves #634
Resolves #613