Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider stabilizing SendChannel.isClosedForSend #3448

Closed
JakeWharton opened this issue Sep 9, 2022 · 2 comments
Closed

Consider stabilizing SendChannel.isClosedForSend #3448

JakeWharton opened this issue Sep 9, 2022 · 2 comments
Labels
channels for 1.7

Comments

@JakeWharton
Copy link
Contributor

It was added in 0.7(!!) and made experimental in 1.0 about two years later. That was now 4 years ago. Time to stabilize?
@JakeWharton JakeWharton changed the title Consider stabilizing SendChannel.isClosedForSend Consider stabilizing SendChannel.isClosedForSend Sep 9, 2022
@JakeWharton JakeWharton mentioned this issue Sep 9, 2022
Open
3 tasks
@qwwdfsad
Copy link
Collaborator

Makes sense.

The biggest blocker was its non-linearizability for buffered channel, but its unlikely to bother anyone and can be changed even in minor release

qwwdfsad added a commit that referenced this issue Nov 1, 2022
@qwwdfsad
Stabilize SendChannel.isClosedForSend
9b344ef 
Fixes #3448
@qwwdfsad
Copy link
Collaborator

We are going to promote it to delicate API along with isClosedForReceive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
channels for 1.7
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeWharton @qwwdfsad