Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.9.0-RC: kotlinx-coroutines-core/jvm/src/internal/ProbesSupport.kt calls kotlinx.coroutines.debug.internal.probeCoroutineResumed #4152

Closed
nreid260 opened this issue Jun 5, 2024 · 1 comment
Closed

1.9.0-RC: kotlinx-coroutines-core/jvm/src/internal/ProbesSupport.kt calls kotlinx.coroutines.debug.internal.probeCoroutineResumed #4152

nreid260 opened this issue Jun 5, 2024 · 1 comment
Labels
bug debug

Comments

@nreid260
Copy link

nreid260 commented Jun 5, 2024

Describe the bug

This seems like an accident. probeCoroutineCreated delegates to kotlin.coroutines.jvm.internal but probeCoroutineResumed delegates to kotlinx.coroutines.debug.internal. Should they not point to the same place?

It also creates a weird build dependency. Now "debug" code is a static dependency of "production" code.
@nreid260 nreid260 added the bug label Jun 5, 2024
@nreid260 nreid260 changed the title kotlinx-coroutines-core/jvm/src/internal/ProbesSupport.kt calls kotlinx.coroutines.debug.internal.probeCoroutineResumed 1.9.0-RC: kotlinx-coroutines-core/jvm/src/internal/ProbesSupport.kt calls kotlinx.coroutines.debug.internal.probeCoroutineResumed Jun 6, 2024
@fzhinkin
Copy link

fzhinkin commented Jun 6, 2024

@nreid260 thanks for reporting! My colleagues will check the issue once they are back from vacation.

qwwdfsad added a commit that referenced this issue Jun 28, 2024
@qwwdfsad
Depend on the stdlib's probeCoroutineResumed in ProbesSupport instead…
7e85673 
… of the unconditional reference of 'kotlinx.coroutines.debug.internal'

Was accidentally introduced in #4058

Fixes #4152
@qwwdfsad qwwdfsad added the debug label Jun 28, 2024
@qwwdfsad qwwdfsad mentioned this issue Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug debug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qwwdfsad @fzhinkin @nreid260