Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue: #1123. Check the job state to make the ResumeOnCompletion … #1124

Closed
wants to merge 2 commits into from
Closed

Fix issue: #1123. Check the job state to make the ResumeOnCompletion … #1124

wants to merge 2 commits into from

Conversation

bennyhuo
Copy link

Trying to fix issue #1123.

@bennyhuo bennyhuo mentioned this pull request Apr 21, 2019
Closed
@elizarov
Copy link
Contributor

Unfortunately, it does not pass the test and it throws the wrong cancellation exception from job. It throws the exception on the job that is being joined, but it should throw an exception on the job that is joining.

@elizarov elizarov closed this Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennyhuo @elizarov