Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make withContext cancellable on return (instead of atomically cancell… #1192

Merged
merged 1 commit into from
May 15, 2019
Merged

Make withContext cancellable on return (instead of atomically cancell… #1192

merged 1 commit into from
May 15, 2019

Conversation

qwwdfsad
Copy link
Collaborator

…able).

* Reasoning about cancellation is simplified in sequential scenarios, if 'cancel' was invoked before withContext return it will throw an exception, thus "isActive == false" cannot be observed in sequential scenarios after cancellation
* withContext now complies its own documentation

Fixes #1177

@qwwdfsad
Make withContext cancellable on return (instead of atomically cancell…
5d5babd 
…able).

    * Reasoning about cancellation is simplified in sequential scenarios, if 'cancel' was invoked before withContext return it will throw an exception, thus "isActive == false" cannot be observed in sequential scenarios after cancellation
    * withContext now complies its own documentation

Fixes #1177
@qwwdfsad qwwdfsad requested a review from elizarov May 14, 2019 12:45
elizarov
elizarov approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qwwdfsad qwwdfsad merged commit c022ab6 into develop May 15, 2019
@qwwdfsad qwwdfsad deleted the with-context-cancellable branch May 15, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov