Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote deprecation levels for release 1.6.0 #3024

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

message = "Use catch { e -> if (predicate(e)) emitAll(fallback) else throw e }",
replaceWith = ReplaceWith("catch { e -> if (predicate(e)) emitAll(fallback) else throw e }")
)
public fun <T> Flow<T>.onErrorCollect(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was @FlowPreview

@qwwdfsad
Copy link
Collaborator Author

BroadcastChannel<T>.asFlow() is left as warning deliberately for now

message = "Use (Throwable) -> Boolean functional type",
replaceWith = ReplaceWith("(Throwable) -> Boolean")
)
public typealias ExceptionPredicate = (Throwable) -> Boolean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that type aliases don't leave a trace in target binaries, so it doesn't make sense to make them hidden, as they would simply become useless?

@qwwdfsad
Copy link
Collaborator Author

Do I understand correctly that type aliases don't leave a trace in target binaries, so it doesn't make sense to make them hidden, as they would simply become useless?

Right. Also, it used to be @FlowPreview

@qwwdfsad qwwdfsad merged commit ae0c842 into develop Nov 16, 2021
@qwwdfsad qwwdfsad deleted the review-deprecations-for-1.6.0 branch November 16, 2021 16:41
yorickhenning pushed a commit to yorickhenning/kotlinx.coroutines that referenced this pull request Jan 28, 2022
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants