Remove w3c usages from wasmJs implementation #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a place where we can read about the rationale of these changes to the stdlib? |
Well, we a have some meeting recording and plan for it, placed here. |
qwwdfsad
approved these changes
May 8, 2024
igoriakovlev
force-pushed
the
yakovlev/remove_w3c_deps
branch
from
9228aee
to
3813390
Compare
igoriakovlev
force-pushed
the
yakovlev/remove_w3c_deps
branch
from
6b85f46
to
702880a
Compare
igoriakovlev
force-pushed
the
yakovlev/remove_w3c_deps
branch
from
702880a
to
f998dbb
Compare
dkhalanskyjb
approved these changes
Jul 9, 2024
ilya-g
reviewed
Jul 10, 2024
| import kotlin.js.* | ||
|
|
||
| public actual typealias W3CWindow = Window | ||
| public actual abstract external class W3CWindow { |
There was a problem hiding this comment.
Does it need to be public? it doesn't seem to be used in public API
dkhalanskyjb
added a commit
that referenced
this pull request
Jul 11, 2024
Accidentally exposed in #4097
dkhalanskyjb
added a commit
that referenced
this pull request
Jul 11, 2024
Accidentally exposed in #4097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a matter of removing w3c declarations from WasmJs stdlib we need to remove its usages from the coroutines.