Support encoding/decoding ByteArrays in parameterized types as ByteStrings. #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is effectively accomplished by propagating the value of `decodeByteArrayAsByteString`, as determined by reading the annotations on the element, down to any `CborReader`s for map- or list-like types. Any `ByteArray` types listed as direct or indirect type argument for these parameterized types will be parsed in the same manner.
christiandeange
added a commit
to christiandeange/ozone
that referenced
this pull request
Aug 1, 2023
Subscription calls differ from query and procedure calls in that they are actually subscriptions to a websocket, not a standard HTTP call. For this reason, they actually respond with a `Flow<*>`, not just one value. Part of the actual CBOR implementation in kotlinx-serialization is adapted here to support byte arrays as byte strings for parameterized types, like List<ByteArray>. Kotlin/kotlinx.serialization#2383
|
Hi, am I correct that your |
|
Yes if that PR is merged, I think this one is relatively redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively accomplished by propagating the value of
decodeByteArrayAsByteString, as determined by reading the annotationson the element, down to any
CborReaders for map- or list-like types.Any
ByteArraytypes listed as direct or indirect type argument forthese parameterized types will be parsed in the same manner.
Solves #2037.