CBOR correctly skips particular values #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you filed an issue somewhere already or you've decided to do a PR right away? |
|
I just made a PR - Apologies if I skipped a step. I would be happy to open an issue or otherwise add to the PR. |
sandwwraith
reviewed
Dec 10, 2024
| if (header == HEADER_ARRAY || header == HEADER_MAP) { | ||
| if (header == HEADER_TAG) { | ||
| readNumber() | ||
| } else if (header == HEADER_ARRAY || header == HEADER_MAP) { |
There was a problem hiding this comment.
cc @JesusMcCloud as author of these changes. I do not see any particular problems, so I'll merge this if you don't have other comments.
There was a problem hiding this comment.
Thanks! Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CBOR "ignoreUnknownKeys" allows for arbitrary content to be skipped.
In the case of an empty map, empty array, or tags on non-map/array values the skip would fail
Included somewhat trimmed down example test.