Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #13

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Cleanup #13

wants to merge 19 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2020

Same as closed pull request. Some more changes as well.

Jan Prudil added 19 commits June 19, 2020 18:42
Remove dependency on utils library
a813602
Remove unused file (accel.h)
d9d7637
Use predefined Pi constant
05b0dfa
Use pow() function instead of acceptable substitute
adc8cb4
Use less magic values
aab9116
Use keywords for booleans
c3361e9
Use hypotenuse function where applicable
3f33c1d
Change int to double where applicable
4399cdf
Remove extraneous comment
36d35bf
Change <math.h> to <cmath>
c184514
Move some variables closer to their first use
05fe4fe
Break settings out into their own data structure
a2d3795
Formatting consistency
1626130
Use struct initializers
59e7eca
Unify init strategy
0729e7d
Unify init strategy
0b2a2ca
Change NULL to nullptr
92f79a3
Improve printf readability
0d0dbb1
Change brace formatting style
c07a71e 
The original was quite sporadic in its use of braces. I don't want to
argue which style is better, but this does at least make it more
consistent across the whole file.
@fwf02 fwf02 mentioned this pull request Aug 3, 2020
Open
@Fosphen
Copy link

Fosphen commented Oct 12, 2020 •
edited
Loading

Hi there, great project !
I would like to suggest adding an option which would allow us to log input statistics.
We would be able to start logging and hop into a game or a Kovaaks drill.
If we have a data table at the end we could plot the iteration of every speed values on a graph and see what speeds are mostly used, and other things like the highest speed reached, the avg etc.
This could really help in chosing good acceleration settings.

I know there is the FancyOutput = 1 setting but it is quite hard to tell anything about your habits with this.

Kind regards
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Fosphen