New parameter "user_strip_at" to remove @domain from user. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prlw1 Thank you for this pull request. I understand your needs, but I'm not sure that I want to merge this feature as it is really specific. Now that we have a way to cleanly inherit from the What do you think of that? |
Unrud
pushed a commit
to Unrud/Radicale
that referenced
this pull request
Aug 30, 2016
This makes it possible to implement Kozea#349 as a Auth module. Another use case would be to encode usernames that contain characters unsupported by the file system.
|
We can safely implement this feature in an auth module now thanks to #500. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a user who configures some clients using a userid and others using an email address, probably because of the clients' differing user interfaces, we found it simplest just to strip the domain from the email address to just use the userid (as they matched) as per this patch.
Comments?