Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixing bookmark-label: contents and text-transform has unexpected results #137

Closed
graingert opened this issue Dec 2, 2013 · 2 comments
Closed

mixing bookmark-label: contents and text-transform has unexpected results #137

graingert opened this issue Dec 2, 2013 · 2 comments
Labels
bug Existing features not working as expected good first issue Issues that can be quite easily solved by Python developers with a good CSS background
Milestone
54.0

Comments

@graingert
Copy link
Contributor

mixing bookmark-label: contents and text-transform has unexpected results:

If you set text-transform on the element, I expect the untransformed element content to appear in the bookmarks. I can't find what the specified behaviour should be.
@SimonSapin
Copy link
Member

Hi. Could you expand? Please provide a code example, the result you get, and what you expected instead.

@graingert
Copy link
Contributor Author

https://github.com/graingert/weasyprint-examples/raw/master/bookmarks.pdf
https://github.com/graingert/weasyprint-examples/raw/master/bookmarks.html

@liZe liZe added bug Existing features not working as expected conformance labels Mar 8, 2016
@liZe liZe mentioned this issue Aug 16, 2016
Closed
@liZe liZe added the good first issue Issues that can be quite easily solved by Python developers with a good CSS background label Mar 23, 2018
@liZe liZe mentioned this issue Mar 29, 2018
Merged
@liZe liZe removed the bug Existing features not working as expected label Apr 1, 2019
@liZe liZe added bug Existing features not working as expected and removed conformance labels Dec 17, 2019
@liZe liZe added this to the 54.0 milestone Sep 6, 2021
@liZe liZe closed this as completed in 85e1ea1 Sep 6, 2021
liZe added a commit that referenced this issue Oct 13, 2021
@liZe
Remove original_text attribute
833afb6 
This "hack" was introduced to ignore the text-transform property for bookmarks.
Now that the whitespace management logic is done after the box creation (just
before building the bookmark label), we can do the same for the text
transformation (just after building the bookmark label).

Related to #607 and #137.
@liZe liZe mentioned this issue Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected good first issue Issues that can be quite easily solved by Python developers with a good CSS background
Projects
None yet
Milestone
54.0
Development

No branches or pull requests
3 participants
@SimonSapin @graingert @liZe