Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fieldset rendering with non-label/input contents #168

Closed
dsas opened this issue Feb 6, 2014 · 5 comments
Closed

Fieldset rendering with non-label/input contents #168

dsas opened this issue Feb 6, 2014 · 5 comments

Comments

@dsas
Copy link

dsas commented Feb 6, 2014

Fieldsets should display their contents with a border all of the way around. This doesn't seem to work if the content is not a label or an input. In this case, I get a border which looks like a big open square bracket, followed by the content on a new line, followed by a big closing square bracket.

The HTML5 spec says that fieldset content model is flow content, so this should work (though I suppose isn't a high priority.)

Here's my HTML:

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
    <title>Test fieldsets over page breaks</title>
</head>
<body>
    <form>
        <fieldset>
            <p>Duis turpis eros, eleifend eget</p>
        </fieldset>
    </form>
</body>
</html>

Here's what I see using master (39a3ee):
screenshot from 2014-02-06 20 58 07
@SimonSapin
Copy link
Member

Hi @dsas. Is it any better if you add fieldset { display: block } to your stylesheet?

@dsas
Copy link
Author

dsas commented Feb 7, 2014

Yes it works as expected then. I notice now that fieldset is not display:block in html5_ua.css, in the Chrome and Firefox default stylesheets it is display:block.

SimonSapin added a commit that referenced this issue Feb 7, 2014
@SimonSapin
Make <fieldset> display: block (See #168)
372bcb5
@SimonSapin
Copy link
Member

Yes, that’s a bug. Fixed.

@dsas
Copy link
Author

dsas commented Feb 7, 2014

Great, thanks @SimonSapin

@SimonSapin
Copy link
Member

Please close the bug if this is OK for you. <fieldset> rendering in web browsers is actually much more complex and under-specified.

@dsas dsas closed this as completed Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsas @SimonSapin