Rely on the font size for rounding bug workaround #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only relying on the line length is awful in real-life test cases when the font size is big and the line short (ex. titles), causing the last word of some lines to disappear. This new workaround gives an 0.2em extra space for latest characters (instead of line-height/10000).
liZe
added a commit
that referenced
this pull request
Apr 25, 2015
Rely on the font size for rounding bug workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only relying on the line length is awful in real-life test cases when the font size is big and the line short (ex. titles), causing the last word of some lines to disappear.
This new workaround gives an 0.2em extra space for latest characters (instead of line-height/10000).