Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace utf8 with utf-8 for gettext/django compatibility #280

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

alexef
Copy link
Contributor

@alexef alexef commented Nov 25, 2015

See: http://stackoverflow.com/questions/4370035/django-makemessages-errors-unknown-encoding-utf8

This will fix:

CommandError: errors happened while running xgettext on __init__.py
xgettext: ./venv/lib/python3.4/site-packages/weasyprint/__init__.py:1: Unknown encoding "utf8".    Proceeding with ASCII instead.
xgettext: Non-ASCII string at ./venv/lib/python3.4/site-packages/weasyprint/__init__.py:145.
          Please specify the source encoding through --from-code or through a comment
          as specified in http://www.python.org/peps/pep-0263.html.

@SimonSapin
Copy link
Member

Sounds like a stupid bug in django-makemessages, but oh well.

SimonSapin added a commit that referenced this pull request Nov 25, 2015
Replace utf8 with utf-8 for gettext/django compatibility
@SimonSapin SimonSapin merged commit 4e8fc27 into Kozea:master Nov 25, 2015
jsonn referenced this pull request in jsonn/pkgsrc Jan 8, 2016
Version 0.25
------------

Released on 2015-12-17.

New features:

* Support the 'q' unit.

Bug fixes:

* `#285: <https://github.com/Kozea/WeasyPrint/issues/285>`_:
  Fix a crash happening when splitting lines.
* `#284: <https://github.com/Kozea/WeasyPrint/issues/284>`_:
  Escape parenthesis in PDF links.
* `#280: <https://github.com/Kozea/WeasyPrint/pull/280>`_:
  Replace utf8 with utf-8 for gettext/django compatibility.
* `#269: <https://github.com/Kozea/WeasyPrint/pull/269>`_:
  Add support for use when frozen.
* `#250: <https://github.com/Kozea/WeasyPrint/issues/250>`_:
  Don't crash when attachments are not available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants