Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kellyroach/fix warnings #191

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kellyroach
Copy link
Contributor

Fix Xcode 9.4.1 Analyzer warnings.

  • Update to Xcode 9.4.1 recommended project settings
  • Fix warning: 'weak' should not be applied to a property declaration in a protocol
  • Convert ImageViewerTests to Swift 4
  • Swift 3 @objc inference in Swift 4 mode is deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant