-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OneLight/TommorowDay themes, update bracket colours #304
Conversation
Thanks, good idea with the matching of brackets to the theme. |
Thanks for merging this 🙂. I will admit though, after diving into some of the internals here I've become afflicted with a growing temptation to try to make a from-scratch-but-copying-a-few-things-from-OhMyREPL fancy REPL package that's put together a bit differently. |
Go for it, it's fun :) |
Gah! Encouragement was the last thing I needed 😝 If anything nice seems to happen I'll let you know. For a while I've thought it's a pity that |
I've been meaning for a long time to allow the Julia REPL to take a "highlighter" that would take the current buffer of the REPL and return a set of bytes and color "tokens" and the REPL would display that colored output. That would allow packages like OhMyREPL to avoid having to do any method overwrites or adding all these awkward keybindings that we do here. |
On a similar note, for a while I've felt Julia could benefit from a "string + text properties" type, which would allow one to say "this word is red" etc. without having to mess around with |
Kristoffer, let me know if you'd be interested in hearing more from me about this. I've just been able to do an evening's work on this, but so far I have an (incremental) history filtering system working which only depends on Base + REPL. Over the weekend I might see how much further I can take this. history-completion-initial-work.mp4 |
this was the case before KristofferC#304
this was the case before #304
Three things (which can be split up, if needed)
Sample screenshot: