Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneLight/TommorowDay themes, update bracket colours #304

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

tecosaur
Copy link
Contributor

Three things (which can be split up, if needed)

  • OneLight theme
  • TomorrowDay theme
  • Updating the rainbow brackets theme

Sample screenshot:

image

@KristofferC KristofferC merged commit f77d8f3 into KristofferC:master Mar 15, 2023
@KristofferC
Copy link
Owner

Thanks, good idea with the matching of brackets to the theme.

@tecosaur
Copy link
Contributor Author

Thanks for merging this 🙂.

I will admit though, after diving into some of the internals here I've become afflicted with a growing temptation to try to make a from-scratch-but-copying-a-few-things-from-OhMyREPL fancy REPL package that's put together a bit differently.

@KristofferC
Copy link
Owner

Go for it, it's fun :)

@tecosaur
Copy link
Contributor Author

tecosaur commented Mar 15, 2023

Gah! Encouragement was the last thing I needed 😝

If anything nice seems to happen I'll let you know.

For a while I've thought it's a pity that julia doesn't come with OhMyREPL, so I might see if I can make something that only depends on JuliaSyntax — which might at least allow this to be more seriously considered 🤞.

@KristofferC
Copy link
Owner

KristofferC commented Mar 15, 2023

I've been meaning for a long time to allow the Julia REPL to take a "highlighter" that would take the current buffer of the REPL and return a set of bytes and color "tokens" and the REPL would display that colored output. That would allow packages like OhMyREPL to avoid having to do any method overwrites or adding all these awkward keybindings that we do here.

@tecosaur
Copy link
Contributor Author

tecosaur commented Mar 15, 2023

On a similar note, for a while I've felt Julia could benefit from a "string + text properties" type, which would allow one to say "this word is red" etc. without having to mess around with printstyled or manually dealing with shell escape codes etc., and also have the advantage of being able to easily fall back to plaintext or even be represented in other formats, e.g. HTML.

@tecosaur
Copy link
Contributor Author

Kristoffer, let me know if you'd be interested in hearing more from me about this. I've just been able to do an evening's work on this, but so far I have an (incremental) history filtering system working which only depends on Base + REPL. Over the weekend I might see how much further I can take this.

history-completion-initial-work.mp4

MarcMush added a commit to MarcMush/OhMyREPL.jl that referenced this pull request Jun 3, 2023
KristofferC pushed a commit that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants