Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExprTools, reuse _timer_expr, rework timeit_debug func def. #117

Merged
merged 3 commits into from
May 11, 2021

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented May 11, 2021

In order to add a feature, I wanted to facilitate code reuse between timer_expr and timer_expr_func. That prompted me to use ExprTools to simplify the implementation, which surfaced a bug similar to #65 (comment). Since I wanted to keep the code reuse, I decided to implement #61 (comment).

Fixes #61

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #117 (ec58e16) into master (90a5ee5) will decrease coverage by 2.78%.
The diff coverage is 92.30%.

❗ Current head ec58e16 differs from pull request most recent head 7591e1a. Consider uploading reports for the commit 7591e1a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   93.10%   90.32%   -2.79%     
==========================================
  Files           4        5       +1     
  Lines         377      372       -5     
==========================================
- Hits          351      336      -15     
- Misses         26       36      +10     
Impacted Files Coverage Δ
src/TimerOutputs.jl 100.00% <ø> (ø)
src/TimerOutput.jl 84.40% <89.28%> (-6.14%) ⬇️
src/precompile.jl 100.00% <100.00%> (ø)
src/utilities.jl 95.23% <0.00%> (-1.59%) ⬇️
src/show.jl 96.22% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8979286...7591e1a. Read the comment docs.

@KristofferC KristofferC merged commit f22efe4 into KristofferC:master May 11, 2021
@maleadt maleadt deleted the refactor branch May 11, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@timeit_debug applied to function introduces type instability
3 participants